Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tuple Cartesian syntax implicit parameter #1811

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Move tuple Cartesian syntax implicit parameter #1811

merged 1 commit into from
Aug 10, 2017

Conversation

DavidGregory084
Copy link
Member

Fixes #1805 by moving the implicit parameter for tuple Cartesian methods from the ops class to the methods. As discussed in the issue this provides better error messages:

[error] C:\Users\gregoryd\Repos\cats\tests\src\test\scala\cats\tests\SyntaxTests.scala:204: could not find implicit value for parameter cartesian: cats.Cartesian[F]
[error]     tfabc mapN f
[error]           ^

instead of:

[error] C:\Users\gregoryd\Repos\cats\tests\src\test\scala\cats\tests\SyntaxTests.scala:204: value mapN is not a member of (F[A], F[B], F[C])
[error]     tfabc mapN f
[error]           ^

@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Aug 10, 2017
@kailuowang kailuowang merged commit 3238de6 into typelevel:master Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@hamishdickson hamishdickson hamishdickson approved these changes

@edmundnoble edmundnoble edmundnoble approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging this pull request may close these issues.
5 participants
@DavidGregory084 @kailuowang @edmundnoble @hamishdickson @LukaJCB